Skip to content

Merge release in master #3441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 12, 2018
Merged

Conversation

rosen-vladimirov
Copy link
Contributor

No description provided.

@rosen-vladimirov rosen-vladimirov changed the title Vladimirov/merge rel master Merge release in master Mar 12, 2018
Natalia-Hristova and others added 4 commits March 12, 2018 10:20
We need to track users that export their projects from playground and opens them in CLI or Sidekick. To support that we introduce playground key in nativescript key in package.json file. For example:
```
{
	"nativescript": {
		"playground": {
			"id": "some user quid",
			"usedTutorial": false // is not obligatory. In case it is present, can be true or false
		}
	}
}
```

If  case when package.json file contains playground key, {N} CLI reads playground data and saves them in userSettings file. If usedTutorial=true is already saved in userSettings file, {N} CLI does not overwrite it. After that {N} CLI deletes playground key from package.json file.

In case when package.json file does not contain playground key, {N} CLI checks if playground key is already saved in userSettings file. It this is the case, {N} CLI reads playground data from userSettings file.
In case project template has a preconfigured plugins data (for example API keys), it will be stored in the template's package.json.
After creating the project, CLI removes all keys except the one defined in `PackageJsonKeysToKeep` array from `app/package.json` file.
So it removes the predefined configuration of the pluginData.
Fix this by adding the entry "pluginsData" in the array, so we'll keep it as well.
Update version.
Update Changelog.
@rosen-vladimirov rosen-vladimirov force-pushed the vladimirov/merge-rel-master branch from b71b770 to 89d426c Compare March 12, 2018 08:39
@rosen-vladimirov rosen-vladimirov merged commit 4210877 into master Mar 12, 2018
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/merge-rel-master branch March 12, 2018 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants